From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 Aug 2013 22:47:44 GMT
Subject: Re: [PATCH v2 05/16] blame: accept multiple -L ranges
Message-ID: <7vk3jye8rz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAPig+cTHbV-ijfXNBn45v2opOH7Jh0A22QaxCeKhRBPA39xAwQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Each constructed blame_entry must own a reference to the suspect.
> o->refcnt should equal the number of blame_entries. At construction, a
> 'struct origin' has refcnt 1. In the original code, which supported
> only a single initial range (blame_entry), we had:
>
>   o = get-initial-suspect();  # refcnt already 1
>   ent->suspect = o;  # refcnt still 1

Ah, of course.

I forgot that I initialized a new origin with refcnt 1 exactly for
this.  As you use it once for each range, you would need to
compensate for it.

Thanks.