From: Junio C Hamano Date: Mon, 12 Sep 2005 22:31:58 GMT Subject: Re: Add "git grep" helper Message-ID: <7virx57w9t.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > Actually, the more I think about it, the more I think Morten was right, > and the git-grep case statement should just put all flags in "$flags", and > any git-ls-files flags can be handled specially before. > > We also need special casing for grep flags that take an argument. So the > end result might be something like the following.. Arrrrrrrrrrrrrrrrrrrgh. Now, whose grep are we going to support? Should we teach every flag GNU grep supports that can take a parameter to the script? Can we cheat and do something like this instead? git grep -B 6 -A 2 frotz -- arch/i386 git grep -B 6 -A 2 frotz --others arch/i386 That is, things up to a known git-ls-files flag or -- are passed to grep and the rest is given to git-ls-files.