From: Junio C Hamano Date: Fri, 11 Nov 2005 06:04:13 GMT Subject: Re: merge-base: fully contaminate the well. Message-ID: <7viruzu3du.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > So the cheap test is to just say > > /* Do we have multiple results? */ > if (result->next) > contaminate_well(result); > > no? Correct. And this is only for really artificial corner case so we should try to avoid for normal cases as much as possible, cheaply. > Btw, I don't think your contamination logic is necessarily complete. We > may not even have parsed some of the commits that end up being on that > strange corner case. I haven't tried walking any other test cases, but wouldn't that be arguing that the our assumption that the current merge-base is at least complete if not optimum?