From: Junio C Hamano Date: Mon, 03 Jul 2006 21:04:10 GMT Subject: Re: [PATCH 1/3] Add read_cache_from() and discard_cache() Message-ID: <7virmepfhx.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > Okay. After reading the comment, I am quite certain we can just set the > index_file_timestamp to 0. Thanks. > So, I still think that these two lines should be in the cleanup part of > get_merge_bases(). I think that is sane -- please make it so. > BTW personally, I prefer the one-function approach, i.e. a flag which says > if it is okay not to clean up. Yup. Agreed.