From: Junio C Hamano <junkio@cox.net>
Date: Tue, 06 Feb 2007 04:26:17 GMT
Subject: Re: [PATCH] Read cvsimport options from repo-config
Message-ID: <7vireflxna.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <3f80363f0702051722x1812228fp1cd7a41dd32b31f3@mail.gmail.com>

I find what your patch does quite sensible, although the
split(/ *(?!:)/) magic might be a bit hard to read for the
uninitiated.

> +		my $arg = 'git-repo-config';
> +		$arg .= ' --bool' if ($o !~ /:$/);
> +
> +        chomp(my $tmp = `$arg --get cvsimport.$key`);
> +		if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {

Can this =~ / --bool / ever match (note the SP after 'l')?