From: Junio C Hamano <junkio@cox.net>
Date: Fri, 25 May 2007 02:38:46 GMT
Subject: Re: [PATCH] fix memory leak in parse_object when check_sha1_signature fails
Message-ID: <7virahtyo9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070525020939.GT28023@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Carlos Rica <jasampler@gmail.com> wrote:
>> When check_sha1_signature fails, program is not terminated:
>> it prints an error message and returns NULL, so the
>> buffer returned by read_sha1_file should be freed before.
> ...
>> 		if (check_sha1_signature(sha1, buffer, size, typename(type)) 
>> 		< 0) {
> ...
>
> gmail strikes again.  The above line is wrapped, which means your
> patch is whitespace damaged and won't apply properly.

That is only between your eyes, imagination and your MUA (hint:
"format: flowed").

For applying after saving it in mbox it does not pose a problem,
but it _does_ affect people who want to comment on the patch
while in MUA.

Is there a way to turn that "format: flawed" off?