From: Junio C Hamano Date: Mon, 05 Nov 2007 19:13:33 GMT Subject: Re: [PATCH] Use parseopts in builtin-fetch Message-ID: <7vir4gqzdu.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071105085513.GB25574@artemis.corp> Pierre Habouzit writes: > On Mon, Nov 05, 2007 at 03:35:34AM +0000, Daniel Barkalow wrote: >> I mostly did this and the next one for practice with the API. I'm >> impressed that "git fetch -vv" is even handled correctly without anything >> special. > > About that: OPTION_BOOLEAN increments the associated variable, to > support this case specifically. > > The last thing that really miss in parse-options is a way to recurse > into a sub-array of struct option, to be able to port the generic diff > and revision arguments. Another micronit is I found lacking is that it is a bit too cumbersome to accept only a subset of integer as a value (e.g. "this option takes a positive integer, not zero nor negative"). The caller can set up a callback to handle that, though.