From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 08 Dec 2007 08:28:44 GMT
Subject: Re: [PATCH 2/3] git-help: add -w|--web option to display html man page in a browser.
Message-ID: <7vir39wpxf.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071202060755.4d6d5ec8.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> diff --git a/help.c b/help.c
> index 0f1cb71..ecc8c66 100644
> --- a/help.c
> +++ b/help.c
> @@ -265,6 +265,12 @@ static void show_info_page(const char *git_cmd)
>  	execlp("info", "info", page, NULL);
>  }
>  
> +static void show_html_page(const char *git_cmd)
> +{
> +	const char *page = cmd_to_page(git_cmd);
> +	execlp("git-browse-help", "git-browse-help", page, NULL);
> +}
> +

This should be execl_git_cmd() to honor GIT_TRACE and to help transition
to bindir != gitexecdir layout, I think.