From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 29 Jan 2008 05:39:27 GMT
Subject: Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain
Message-ID: <7vir1dqjg0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <87ve5dicih.wl@mail2.atmark-techno.com>

Yasushi SHOJI <yashi@atmark-techno.com> writes:

> This patch effectively revert the commitdiff plain part of the commit
>
> 	59b9f61a3f76762dc975e99cc05335a3b97ad1f9
>
> which converted from print to here-doc. but it doesn't
> explain why in the commit log.

I think the patch makes sense but the above is misleading.  Read
it again.

Doesn't it sound like you are accusing that 59b9f61a introduced
a regression when it converted existsing "print utf8()" to
"print <<here-doc" without saying that is what it is doing?

I think the change in that commit was meant for writability (I
do not necessarily think here-doc is good for readability), and
I personally do not care---Perl is ugly to read either way ;-)