From: Junio C Hamano Date: Wed, 05 Nov 2008 07:03:42 GMT Subject: Re: [PATCH 5/5] git send-email: turn --compose on when more than one patch. Message-ID: <7viqr2mz75.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20081105033151.GB24886@coredump.intra.peff.net> Jeff King writes: > On Tue, Nov 04, 2008 at 03:54:54PM -0800, Junio C Hamano wrote: > >> Pierre Habouzit writes: >> >> > Automatically turn --compose on when there is more than one patch, and >> > that the output is a tty. >> >> I do not think this is a good idea. I suspect I am not the only person >> who uses "format-patch --cover-letter", edit the files to review and >> prepare, and runs send-email to fire them off. > > Maybe a config option to turn this behavior on? It seems specific to > different workflows (i.e., whether or not you are using "git send-email > $REVS" or using format-patch first). Yeah, if send-email did not have --compose to begin with, we could just say "don't use --compose; use --cover-letter when you use send-email to front-end format-patch instead", but some people perhaps are used to run format-patch separately without --cover-letter and then create the cover letter from scratch with --compose (which seems a bit more work to me, though). So I am not opposed to a sendemail.foo configuration option.