From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 29 Nov 2008 22:26:49 GMT
Subject: Re: [PATCHv2ter 2/2] gitweb: clean up gitweb_check_feature() calls
Message-ID: <7viqq6yxqu.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <cb7bb73a0811291416h4c227411u61bfe7033f0d2bae@mail.gmail.com>

"Giuseppe Bilotta" <giuseppe.bilotta@gmail.com> writes:

> And this is precisely the reason why the first time I sent the patch I
> did the restyling in the same go: by not touching the
> clueless/careless callers and instead bringing gitweb_check_feature to
> act in scalar context, it would automatically fix those broken usages,

... which is very bad for reviewability purposes.

By explicitly fixing them before doing the "this will sweep all the
potential bugs under the rug", you can demonstrate a lot more clearly why
these changes are necessary.