From: Junio C Hamano Date: Tue, 10 Feb 2009 15:59:16 GMT Subject: Re: [PATCH] Make repack less likely to corrupt repository Message-ID: <7viqninuzv.fsf@gitster.siamese.dyndns.org> In-Reply-To: <200902100807.40417.robin.rosenberg@dewire.com> Robin Rosenberg writes: > måndag 09 februari 2009 07:04:46 skrev Junio C Hamano: >> What's troubling more is that this would seem to leave the result even >> more inconsistent if there are more than one packs that need to be >> replaced. > > Why? We don't prune the old objects if we fail. The result might be a lot > of redundancy, but nothing should be lost. I was not talking about any loss. The result would be a funny mixture of permutations of {old-,}pack-*.{pack,idx} the user needs to match up after figuring out what corresponds with what other one, and I think an expert who is asked for help would have hard time matching them up too, even though that is what you suggested in the message. That troubled me and I was wondering if we can make the recovery simpler for the users.