From: Junio C Hamano Date: Fri, 20 Feb 2009 06:11:24 GMT Subject: Re: [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Message-ID: <7viqn5iqnn.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20090220030245.GC22419@coredump.intra.peff.net> Jeff King writes: > Other than that, these all look pretty straightforward. Probably the > shell scripts should be switched to match, too. But it would be nice to > hear from Junio first that this cleanup is even desired (so you don't > waste time). I think it is a good thing to do. If the pre-release-freeze is a good time to do so it is a different matter. A good way to judge would be how much of these overlap with "git diff master next" (smaller the better, obviously).