From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 May 2009 04:21:32 GMT
Subject: Re: [PATCH 0/5] gitweb: Some code cleanups (up to perlcritic --stern)
Message-ID: <7viqk8s20j.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200905110333.52127.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> On Mon, 11 May 2009, Junio C Hamano wrote:
>
>> But this series, when queued to 'pu', seems to break t9500; I haven't
>> looked at the breakage myself yet.
>
> I'm sorry about that. My bad. The fix is in the email (unless you
> prefer for me to just resend the series)...

That's Ok.  I had them near the tip of 'pu', and I can just replace them.

But this episode does not give much confidence in Perl::Critic does it?
The runtime "use strict" diagnosed undeclared globals in the cleaned up
code, but presumably the Critic did not complain anything about it, right?