From: Junio C Hamano Date: Thu, 27 Aug 2009 04:57:16 GMT Subject: Re: [PATCH v3] import-tars: Allow per-tar author and commit message. Message-ID: <7viqg96ehf.fsf@alter.siamese.dyndns.org> In-Reply-To: <20090826193015.962A7189B12@perkele> Peter Krefting writes: > + while () > + { > + if (/^Committer:\s+([^<>]*)\s+<(.*)>\s*$/i) > + { > + $this_committer_name = $1; > + $this_committer_email = $2; > + } > + elsif (/^Author:\s+([^<>]*)\s+<(.*)>\s*$/i) > + { > + $this_author_name = $1; > + $this_author_email = $2; > + } > + else > + { > + $commit_msg .= $_; > + } Do you really want to slurp Committer:/Author: lines from _anywhere_ in the file? Wouldn't it make more sense to vaguely emulate e-mail message format with headers, empty-line and then body that is free form?