From: Junio C Hamano Date: Tue, 01 Dec 2009 00:21:57 GMT Subject: Re: [PATCH] get_ref_states: strdup entries and free util in stale list Message-ID: <7viqcrbl22.fsf@alter.siamese.dyndns.org> In-Reply-To: <0458f16c6ce906997aaf357c0c7368841ae83c36.1259625072.git.bert.wesarg@googlemail.com> Bert Wesarg writes: > Signed-off-by: Bert Wesarg Hmm, the Subject: matches what the code does, but nobody mentions why it is necessary (iow, what breaks in the current code and what becomes better if the patch is applied). The blank space before your "S-o-b:" line is for you to describe these things. > --- > builtin-remote.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/builtin-remote.c b/builtin-remote.c > index 7916626..bb72e27 100644 > --- a/builtin-remote.c > +++ b/builtin-remote.c > @@ -272,7 +272,9 @@ static int get_ref_states(const struct ref *remote_refs, struct ref_states *stat > die("Could not get fetch map for refspec %s", > states->remote->fetch_refspec[i]); > > - states->new.strdup_strings = states->tracked.strdup_strings = 1; > + states->new.strdup_strings = > + states->tracked.strdup_strings = > + states->stale.strdup_strings = 1; > for (ref = fetch_map; ref; ref = ref->next) { > unsigned char sha1[20]; > if (!ref->peer_ref || read_ref(ref->peer_ref->name, sha1)) > @@ -768,7 +770,7 @@ static void clear_push_info(void *util, const char *string) > static void free_remote_ref_states(struct ref_states *states) > { > string_list_clear(&states->new, 0); > - string_list_clear(&states->stale, 0); > + string_list_clear(&states->stale, 1); > string_list_clear(&states->tracked, 0); > string_list_clear(&states->heads, 0); > string_list_clear_func(&states->push, clear_push_info); > -- > 1.6.6.rc0.253.g1ec3