From: Junio C Hamano Date: Tue, 24 May 2011 21:24:37 GMT Subject: Re: [PATCH] checkout: honor advice.detachedHead when reattaching to a branch Message-ID: <7vipsz7pwq.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110524202723.GG584@sigill.intra.peff.net> Jeff King writes: >> @@ -668,8 +671,6 @@ static void orphaned_commit_warning(struct commit *commit) >> die("internal error in revision walk"); >> if (!(commit->object.flags & UNINTERESTING)) >> suggest_reattach(commit, &revs); >> - else >> - describe_detached_head("Previous HEAD position was", commit); >> } > > Wait, I thought we were keeping this, per your argument above? Well, I do not have very strong preference either way. I didn't really argue for or against. I just explained it might be useful. Will resurrect.