From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 01 Aug 2011 00:01:22 GMT
Subject: Re: [RFC/PATCH] ls-files: fix pathspec display on error
Message-ID: <7vipqiknjh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110729130330.GA31941@toss.lan>

Clemens Buchacher <drizzd@aon.at> writes:

> The following sequence of commands reveals an issue with error
> reporting of relative paths:
>
>  $ mkdir sub
>  $ cd sub
>  $ git ls-files --error-unmatch ../bbbbb
>  error: pathspec 'b' did not match any file(s) known to git.
>  $ git commit --error-unmatch ../bbbbb
>  error: pathspec 'b' did not match any file(s) known to git.
>
> This bug is visible only if the normalized path (i.e., the relative
> path from the repository root) is longer than the prefix.
> Otherwise, the code skips over the normalized path and reads from
> an unused memory location which still contains a leftover of the
> original command line argument.
>
> So instead, use the existing facilities to deal with relative paths
> correctly.

Sounds sane; tests?