From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 20 Nov 2011 21:10:35 GMT
Subject: Re: [msysGit] Re: [PATCH 1/2] MSVC: Do not close stdout to prevent a crash
Message-ID: <7vipmeijp0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4EC8C7FE.5050903@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> But in the description of fclose() there is also:
>
>   After the call to fclose(), any use of stream results in undefined
>   behavior.
>
> And we do call fclose(stdout) in cmd_format_patch.

Yeah; this means the "in case builtin implementation is too lazy to clean
up after themselves, run_builtin() will clean things up for them" approach
taken by 0f15731 (Check for IO errors after running a command, 2007-06-24)
fundamentally does not work, which is a bit sad.