From: Junio C Hamano Date: Thu, 08 Mar 2012 22:13:36 GMT Subject: Re: [PATCH 2/2] rebase -i: new option --name-rev Message-ID: <7vipiebv1r.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vaa3qewqw.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Thomas Rast writes: > >> Dominique Quatravaux writes: >> >>> If set, the second column of the rebase todo contains named revisions (obtained >>> with git name-rev) instead of short SHA1s. >> >> Hum. I'm not sure yet if I find that very useful, since frequently the >> names will just be 'topic', 'topic~1', ...., 'topic~N' if you are >> rebasing a topic with N+1 commits not in master. But you might, so who >> am I to judge. > > I think the only use case where this might be useful is when you > have totally undescriptive one-line description to your commits that > they alone do not help distinguishing the commits being picked, e.g. > ... This may need a bit of clarification for readers from the future. If you _were_ somehow interactively rebasing changes made on two or more branches into a single branch, knowing which branch each commit came from may have value, even if your commit titles are descriptive enough. Today's "git rebase -i" wouldn't do something like that, and we will not know how the user would interact with such a yet-to-be-written tool, so it is too early to judge if using "topic~1" is the desired improvement or not at this point.