From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 12 Apr 2012 18:27:10 GMT
Subject: Re: [PATCH 8/9 v12] difftool: teach difftool to handle directory diffs
Message-ID: <7viph46c1t.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1334236726-18393-1-git-send-email-tim.henigan@gmail.com>

Tim Henigan <tim.henigan@gmail.com> writes:

> +sub setup_dir_diff
> +{
> +	# Run the diff; exit immediately if no diff found
> +	my $cmd = "git diff --raw --no-abbrev -z " . join(" ", @ARGV);
> +	my $diffrtn = `$cmd` or die $!;

Why this change?  It looks like a rather unpleasant regression compared to
the previous one that used "command_oneline", so that each element of
@ARGV was given as a single argument to the command.  Now, you are
splitting any argument that has $IFS in it.