From: Junio C Hamano <junkio@cox.net>
Date: Mon, 01 Aug 2005 00:11:20 GMT
Subject: Re: [PATCH] Added hook in git-receive-pack
Message-ID: <7vhdeabjo7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0507311627280.14342@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

> In the "central repo model" you have another issue - you have potentially
> parallell pushes to different branches with no locking what-so-ever (and
> that's definitely _supposed_ to work), and I have this suspicion that the 
> "update for dumb servers" code isn't really safe in that setting anyway. I 
> haven't checked.

You are absolutely right.  It should grab some sort of lock
while it does its thing (would fcntl(F_GETLK) be acceptable to
networked filesystem folks?).

I have one question regarding the hooks.  We seem to prefer
avoiding system and roll our own.  Is there a particular reason,
other than bypassing the need to quote parameters for shell?