From: Junio C Hamano Date: Wed, 07 Jun 2006 05:58:04 GMT Subject: Re: http-fetch segfault fix? Message-ID: <7vhd2xld77.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <1149658914.5648.5.camel@dv> Pavel Roskin writes: > The Valgrind diagnostics confirms that obj_req->slot is not initialized > (as opposed to being a pointer to a freed area or something else): > > ==27182== Conditional jump or move depends on uninitialised value(s) > ==27182== at 0x4070EA: abort_object_request (http-fetch.c:1059) > ==27182== by 0x4071CE: fetch_object (http-fetch.c:1078) > ==27182== by 0x4073EC: fetch (http-fetch.c:1126) > ==27182== by 0x403125: loop (fetch.c:180) > ==27182== by 0x403369: pull (fetch.c:248) > ==27182== by 0x407A13: main (http-fetch.c:1271) > > Line 1059 is: > if (obj_req->slot) { Thanks. That is indeed a very good sign.