From: Junio C Hamano <junkio@cox.net>
Date: Tue, 05 Dec 2006 01:10:50 GMT
Subject: Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too
Message-ID: <7vhcwbkuzp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061205010428.GA26687@soma>

Eric Wong <normalperson@yhbt.net> writes:

> Junio C Hamano <junkio@cox.net> wrote:
>> 
>> Please CC people who are primarily working on the part of the
>> system you are improving.  In the case of git-svn that would be
>> Eric Wong.
>
> Yes, CCs regarding git-svn would be much appreciated, thanks.
> ...
> Please fix the coding style so that it's consistent with the rest of
> git-svn:

Thanks Eric for your quick response.

> a) indentation is done with hard tabs
> b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"
>
> Also, adding tests would be helpful in helping me maintain it (I'm not
> a regular svk user, so I don't want to break anything you've done down
> the line).

Another request from the maintainer is to Sign-off the patches.