From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 02 Mar 2008 17:50:55 GMT
Subject: Re: [PATCH] builtin clone: support bundles
Message-ID: <7vhcfpnhfk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0803021731400.22527@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Sun, 2 Mar 2008, Daniel Barkalow wrote:
>
>> On Sun, 2 Mar 2008, Johannes Schindelin wrote:
>> 
>> > +	for (i = 0; i < ARRAY_SIZE(bundle_suffix); i++) {
>> > +		const char *path;
>> > +		path = mkpath("%s%s", repo, bundle_suffix[i]);
>> > +		if (!stat(path, &st) && S_ISREG(st.st_mode)) {
>> > +			*is_bundle = 1;
>> > +			return xstrdup(make_absolute_path(path));
>> 
>> The problem I'm seeing in general is that origin/next's make_absolute_path 
>> doesn't work on a regular file in the current directory. How are you 
>> getting those tests to pass?
>
> http://repo.or.cz/w/git/dscho.git?a=commitdiff;h=d066bd60e5a93d69c47318cf6e71f77c84b737e6

FYI, I already queued this for 'master'.