From: Junio C Hamano Date: Fri, 25 Jul 2008 16:33:56 GMT Subject: Re: [PATCH] Avoid warning when From: is encoded Message-ID: <7vhcadudmz.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1216991208-18782-1-git-send-email-4ux6as402@sneakemail.com> Peter Valdemar Mørch <4ux6as402@sneakemail.com> writes: > From: Peter Valdemar Mørch > > In commit 0706bd19ef9b41e7519df2c73796ef93484272fd $1 is used from a regexp > without using () to set up $1. Later, when that value was used, it caused a > warning about a variable being undefined. > > Signed-off-by: Peter Valdemar Mørch Thanks. The patch is obviously correct; I think you are fixing 8291db6 (git-send-email: add charset header if we add encoded 'From', 2007-11-16), not 0706bd1 (send-email: specify content-type of --compose body, 2008-03-28). Will apply to maint and merge upwards.