From: Junio C Hamano Date: Mon, 11 Aug 2008 18:47:07 GMT Subject: Re: [PATCH 2/2] builtin-merge: avoid run_command_v_opt() for recursive Message-ID: <7vhc9rxuc4.fsf@gitster.siamese.dyndns.org> In-Reply-To: Miklos Vajna writes: > The try_merge_strategy() function always ran the strategy in a separate > process, though this is not always necessary. The recursive strategy can > be called without a fork(). This patch adds a check, and calls recursive > in the same process without wasting resources. Yes, it saves a fork, but is this really worth it in the bigger picture? Doesn't the current code structure have benefit of allowing git-merge itself do necessary clean-up action when merge-recursive calls any of the die() it has in many places?