From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 22 Feb 2009 16:48:54 GMT
Subject: Re: [PATCH v2 0/4] Add more tests of cvsimport
Message-ID: <7vhc2m2z9l.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1235221480-31473-1-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> Thanks for all the feedback.  I think I have incorporated it all:
>
> - Renamed the library from t/t96xx/cvs-lib.sh to t/lib-cvs.sh.
>
> - Added t/t9601/cvsroot/.gitattributes to avoid whitespace warnings.
>
> - Fixed the "cvs co" command for when checking out a branch/tag.
>
> - Implemented a recursive diff in test_cmp_branch_tree rather than
>   relying on GNU diff features.  It is only a dozen lines of code, but
>   please review this carefully as I'm not such a shell jockey.

Thanks.

>   ....  It would also have the disadvantage of
>   making "git cvsimport" tests fail if there are bugs in "git diff".

This is very true and for the same reason we tend to avoid using it
(especially "git diff --no-index").  The tests are not making sure nobody
has broken "git diff" after all.