From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Mar 2009 18:03:14 GMT
Subject: Re: [PATCH 3/5] Add option for using a foreign VCS
Message-ID: <7vhc1h5vkt.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0903251042280.19665@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

>> > -	if (!prefixcmp(url, "rsync:")) {
>> > +	if (remote && remote->foreign_vcs) {
>> > +	} else if (!prefixcmp(url, "rsync:")) {
>> 
>> 	if (...) {
>>         	; /* empty */
>> 	} else ...
>
> I don't think I've ever tried writing an empty block for git before. It's 
> braces containing a semicolon and comment? (Of course, the reason I wrote 
> this one this way is so that the next patch could put two "+" lines in 
> there and have no "-" lines)

Wasn't a serious "this has to be the final style" suggestion, but more
about "what do you mean by this?  are you going to add more code here in
the later round?" question.