From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Jun 2009 06:57:01 GMT
Subject: Re: [PATCH v2 2/6] add a test for git-send-email for threaded mails without chain-reply-to
Message-ID: <7vhbyr8b7m.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200906080837.31548.markus.heidelberg@web.de>

Markus Heidelberg <markus.heidelberg@web.de> writes:

>> What can be done to make the test better?
>
> Is this change sufficient? Dumping the stdout into a file and grepping
> this.

Yup, that is better for test scripts.

>
>
>  t/t9001-send-email.sh |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index ce26ea4..8f810ab 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -621,4 +621,15 @@ test_expect_success 'in-reply-to but no threading' '
>  	grep "In-Reply-To: <in-reply-id@example.com>"
>  '
>  
> +test_expect_failure 'threading but no chain-reply-to' '
> +	git send-email \
> +		--dry-run \
> +		--from="Example <nobody@example.com>" \
> +		--to=nobody@example.com \
> +		--thread \
> +		--nochain-reply-to \
> +		$patches $patches >stdout &&
> +	grep "In-Reply-To: " stdout
> +'
> +
>  test_done
> -- 
> 1.6.3.2.220.gb421