From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 21 Jun 2009 06:56:43 GMT
Subject: Re: [PATCH v2 2/2] rebase -i: use config file format to save author information
Message-ID: <7vhbyat6qc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.2.00.0906210244510.2147@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

>> Why is this a good change?
>
> It was always using a temporary file; it just used to use a temporary file 
> that was a shell script fragment and needed to be read with "eval". It 
> can't be done entirely in core because it may be determined before a 
> conflict and only used when run with --continue after the user resolves 
> the conflict.

Ahh, Ok.

Using a _known_ and defined format, instead of ad-hoc scriptlet, is an
improvement.

I still wonder if we can avoid using three separate "git show" and "git
config" invocations, though.  But a half of that inefficiency will go away
when this is migrated to C, as a single git_config() will grab all three, 
although the writing side is still very inefficient X-<.