From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 Aug 2009 05:13:03 GMT
Subject: Re: [RFC PATCH v2 4/4] read-tree: add --no-sparse to turn off sparse hook
Message-ID: <7vhbwforvk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <fcaeb9bf0908101838k37751fclac5c572eb042138e@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

>> Hmm.  I understand that the assumption is that memset(&opts, 0,
>> sizeof(opts)); should give you a sensible default, but I cannot avoid
>> noticing that "no_sparse_hook = 0" is a double negation, something to be
>> avoided...
>
> skip_sparse_hook then? :-)

Why not making the hook to be skipped by default, and pass an explicit
option to trigger the hook?

I like Dscho's other suggestion to use patterns like .gitignore instead of
using hook scripts that needs to be ported across platforms, by the way.