From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 23 Oct 2009 00:28:59 GMT
Subject: Re: [PATCH] describe: when failing, tell the user about options that work
Message-ID: <7vhbtrdkc4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.0910222011200.21460@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> writes:

> On Thu, 22 Oct 2009, Junio C Hamano wrote:
>
>> Alex Riesen <raa.lkml@gmail.com> writes:
>> 
>> > These are quite verbose. Could they be conditional on something like
>> > advice.describeHints?
>> 
>> Concurred.  Please make it so.
>
> I don't have a strong opinion either ways, but is having a less verbose 
> message in the _error_ path really a big issue?

Thanks for catching a thinko---I somehow thought the patch was about
warning when we give an annotated tag that is farther than an unannotated
one.

It should be good enough to unconditionally give hints upon an error, as
long as they are correct.