From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 20 Nov 2009 07:53:37 GMT
Subject: Re: [PATCH] gitk: Use git-difftool for external diffs
Message-ID: <7vhbsp7htq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <19205.50406.91209.309984@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> writes:

> I have no problem with using git difftool if the underlying git is new
> enough, I just don't want gitk to explode when it isn't.

I somehow doubt there are many users who use pre 1.6.3 git but keep their
gitk separately updated to very recent version, so personally I wouldn't
worry too much about this.

> Also, I don't think we should remove the ability for the user to
> choose which external diff tool to use.

This is a larger concern.  Does "difftool" allow use of an arbitrary tool
like how gitk does (I have a suspicion that it is not as flexible)?