From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 01 Mar 2010 02:00:17 GMT
Subject: Re: 'git add' regression in git-1.7?
Message-ID: <7vhbp0ls26.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100219082445.GB13691@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I'm not sure of the right way to fix this. We can drop further down into
> the directory hierarchy when doing COLLECT_IGNORED and look for actual
> files, but that may have a negative performance impact.

Wouldn't that have negative correctness impact?  I don't see an obvious
way out, other than perhaps checking the set of pathspecs twice.  One
thing that might help is to carry the seen[] array a bit longer so that we
do not have to lose sight of what paths we were given but didn't match.