From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 13 Mar 2010 22:24:02 GMT
Subject: Re: [PATCH] git status: ignoring untracked files must apply to submodules too
Message-ID: <7vhboj6et9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B9C0AFB.1050306@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> Since 1.7.0 submodules are considered dirty when they contain untracked
> files. But when git status is called with the "-uno" option, the user
> asked to ignore untracked files, so they must be ignored in submodules
> too. To achieve this, the new flag DIFF_OPT_IGNORE_UNTRACKED_IN_SUBMODULES
> is introduced.
>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> ---
>
> This patch applies on top of current pu.
>
> I'm open to suggestions for a shorter name for the new diff option
> IGNORE_UNTRACKED_IN_SUBMODULES; I did not manage to come up with a
> shorter yet still descriptive enough name.

Why do you even need that flag?  Isn't it the matter of deciding to ignore
or pay attention to the DIRTY_SUBMODULE_UNTRACKED bit in the return value
of is_submodule_modified(), depending on whether the toplevel wt_status
was called with -uno?