From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 Dec 2010 19:00:37 GMT
Subject: Re: [PATCH 04/19] Convert struct diff_options to use struct pathspec
Message-ID: <7vhbeh1oru.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1292233616-27692-5-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> diff --git a/diff-lib.c b/diff-lib.c
> index 392ce2b..3b809f2 100644
> --- a/diff-lib.c
> +++ b/diff-lib.c
> @@ -501,7 +501,7 @@ int do_diff_cache(const unsigned char *tree_sha1, struct diff_options *opt)
>  	active_nr = dst - active_cache;
>  
>  	init_revisions(&revs, NULL);
> -	revs.prune_data = opt->paths;
> +	revs.prune_data = opt->pathspec.raw;
>  	tree = parse_tree_indirect(tree_sha1);
>  	if (!tree)
>  		die("bad tree object %s", sha1_to_hex(tree_sha1));

Hopefully the prune_data will become opt->pathspec not "raw" and use your
generalied/unified pathspec matching code in later patches in the series,
yes?

Other than that (no, "including that", really), looks nicely done.