From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 May 2011 00:12:47 GMT
Subject: Re: [PATCHv4 08/10] send-pack/receive-pack: Allow server to refuse pushing too large packs
Message-ID: <7vhb8lrm68.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1306111923-16859-9-git-send-email-johan@herland.net>

Johan Herland <johan@herland.net> writes:

> Add a new receive.packSizeLimit config variable which defines an upper
> limit on the pack size to accept in a single push.
>
> This limit is advertised to clients, using the new "limit-pack-size=<num>"
> capability.

Continuing my comments to 7/10, this shouldn't be closely tied to "pack",
but a more abstract concept of "total transferred data in bytes".

Aside from the name, the implementation looks fine, modulo that it should
not be passing --max-pack-size but --max-total-pack-size to the underlying
pack-objects command.

Thanks.