From: Junio C Hamano Date: Mon, 05 Mar 2012 23:27:50 GMT Subject: Re: [PATCH (for maint)] gitweb: Fix fixed string (non-regexp) project search Message-ID: <7vhay2y6fd.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vd38r2d8y.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Jakub Narebski writes: > >>> Hmph, didn't you already call fill_project_list_info(\@projects) before >>> search_projects_list() already? >> >> True. Sorry about that. >> >> Can you fix that, or should I resend? > > Could you check the following two diffs? > > $ git show debd1c2 > > This is jn/maint-do-not-match-with-unsanitized-searchtext that > should be merged to maintenance track that lack the lazy filling. > > And then > > $ git show --first-parent d4b52c2 > > This is how the above was merged to 'pu' and the conflict resolution > should be the same when we merge it to 'master'. As our @projects may > still be only sparsely filled when search_projects_list() returns, > we do call fill_project_list_info(\@projects) ourselves with the > lazy filling codebase. The latter is now $ git show --first-parent 657c6d0 on today's 'pu'. Thanks.