From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Sep 2012 20:08:55 GMT
Subject: Re: [PATCHv4] clone --single: limit the fetch refspec to fetched branch
Message-ID: <7vhaqwv2co.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8Bsps_-RaXdBd9ipWPvJukjK7mRN_wG2ezEL5d4JLyx+g@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> --mirror --single-branch combination does not look right. The "heads/"
> part is missing..

What does it supposed to do in the first place?  "mirror" is
primarily about grabbing everything without leaving stuff out, and
"single" is about grabbing only one thing without other stuff.  It
smells like a nonsense case we didn't even bother to catch and
diagnose as an error to me.

Besides, mirror implies bare, so we would expect to see

    refs/heads/$single:refs/heads/$single

and that matches what the "single" gives us without "mirror", no?

How about explicitly forbidding that combination, or ignoring mirror
when single is given?