From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 21 Sep 2012 22:30:28 GMT
Subject: Re: [PATCH] t/test-lib.sh: do not trust $SHELL
Message-ID: <7vhaqr3t6j.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m2k3vn9gyu.fsf@igel.home>

Andreas Schwab <schwab@linux-m68k.org> writes:

> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> My SHELL_PATH is not set, and I can see SHELL_PATH ?= $(SHELL) in the
>> Makefile.  Which shell is it supposed to point to?
>
> Inside a makefile the variable SHELL is special in that it is never
> imported from the environment.  If not set it defaults to /bin/sh.

Ahh, I forgot about that.  Then the current construct is perfectly
fine.

The reference to ${SHELL-/bin/sh} in the test need to be updated to
SHELL_PATH as Peff suggested in the other subthread.

Thanks.