From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 29 Dec 2012 16:54:41 GMT
Subject: Re: [PATCH 1/4] hooks: Add function to check if a hook exists
Message-ID: <7vhan4g5ny.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121229145032.GB3789@pug.qqx.org>

Aaron Schrab <aaron@schrab.com> writes:

> Since I'm going to be changing the interface for this hook in v2 of
> the series so that it will be more complicated than can be readily
> addressed with the run_hook() API (and will have use a fixed number of
> arguments anyway) I'll be dropping the run_hook_argv() function.

Just to make sure there is no misunderstanding (sorry for sending
the message without finishing it with this clarification at the end
in the first place).  I didn't mean that converting all of the
existing callers must come earlier than introducing a new hook
invoker.

I just wanted to make sure that we are aware that we are adding to
our technical debt, if we are adding another that is also
specialized; as the proposed interface looked sufficiently generic,
it would be the ideal one to make _other_ ones thin wrappers around
it to unify the various codepaths.

Thanks.