From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 28 Jan 2013 20:36:12 GMT
Subject: Re: [PATCH v2 3/4] mergetool--lib: Add functions for finding available tools
Message-ID: <7vham1vydf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130128193700.GB7498@serenity.lan>

John Keeping <john@keeping.me.uk> writes:

>> +			printf "%s%s\n" "$per_line_prefix" "$tool"
>
> This needs to be:
>
>     printf "$per_line_prefix%s\n" "$tool"
>
> since $per_line_prefix is usually '\t\t' which isn't expanded if we
> format it with %s - an alternative would be to change the value passed
> in to '$TAB$TAB' with literal tabs.

I would prefer the latter, actually.  I do understand the
convenience of being able to write backslash-t, but I do not think
it outweighs the potential risk of mistakingly passing a string with
per-cent in it.