From: Junio C Hamano Date: Mon, 15 Apr 2013 17:38:20 GMT Subject: Re: [PATCH 12/33] peel_object(): give more specific information in return value Message-ID: <7vhaj7wv77.fsf@alter.siamese.dyndns.org> In-Reply-To: <1365944088-10588-13-git-send-email-mhagger@alum.mit.edu> Michael Haggerty writes: > Instead of just returning a success/failure bit, return an enumeration > value that explains the reason for any failure. This will come in > handy shortly. > > Signed-off-by: Michael Haggerty > --- This is a valid rewrite because all existing callers check if the return value is 0 and does not check the error code against -1. Looking good so far.