From: Junio C Hamano <junkio@cox.net>
Date: Fri, 18 Nov 2005 23:42:12 GMT
Subject: Re: [PATCH rev-list.c] max-count in terms of intersection
Message-ID: <7vfyptfrqj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051118224233.50766.qmail@web31805.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

>> This makes sense, but I wonder if the same logic applies to
>> max_age as well.  If we have clock-skewed commits that are
>> skipped by the DENSE processing, we probably do not want them to
>> be affecting what to do on the commits that matter.
>
> As far as I understand it, I think max-age is fine the way
> it is.  After all, max-age depends on date/time which is
> absolute (i.e. applies to commits in the whole set and in
> the intersection just the same).

It is recorded absolutely but what if committer's clock is
broken on one commit but not others, and if you are not using
the default sort_by_date() (e.g. --topo-order)?