From: Junio C Hamano <junkio@cox.net>
Date: Thu, 22 Jun 2006 09:01:46 GMT
Subject: Re: [PATCH] [RFC] Introduce Git.pm
Message-ID: <7vfyhxtvgl.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060622003546.17760.23089.stgit@machine.or.cz>

Petr Baudis <pasky@suse.cz> writes:

> This patch introduces a very basic and barebone Git.pm module
> with a sketch of how the generic interface would look like;

In addition to my previous comments...

> +  my $version = Git::generic_oneval('version');
> +  my $lastrev = $repo->generic_oneval('rev-list', '--all');
> +...
> +=item generic_oneline ( COMMAND [, ARGUMENTS... ] )
> +...
> +sub generic_oneline {
> +	my $fh = generic(@_);
> +	my $line = <$fh>;
> +	close $fh;
> +	chomp $line;
> +	return $line;
> +}

Let's have a cleaned up version of Git.pm, Makefile changes and
changes to git-fmt-merge-msg.perl that shows how to use the
module.  Being in-tree would help people to view, use and
comment on it.