From: Junio C Hamano Date: Fri, 01 Sep 2006 19:56:31 GMT Subject: Re: Mozilla .git tree Message-ID: <7vfyfb5pjk.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > On Fri, 1 Sep 2006, A Large Angry SCM wrote: >> >> Unfortunately, the zlib CRC is of the _uncompressed_ data [1], so >> inflating the stream is still necessary to check for corruption. > > I don't think that is unfortunate. > > We really should inflate the stream anyway, since not only inflating it, > but also applying any deltas to the base object is really the only way to > verify its correctness for a delta thing. Otherwise, the SHA1 of the base > could be totally corrupt. > > And once you inflate it and apply all deltas, you obviously also get the > full SHA1 check, so you're _really_ safe. > > So let's do the really safe thing first, and see if it actually results in > any problems. I think this makes sense.