From: Junio C Hamano Date: Tue, 31 Oct 2006 03:02:27 GMT Subject: Re: [PATCH 1/2] Allow '-' in config variable names Message-ID: <7vfyd5rxvg.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7vodrtv2wy.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Linus Torvalds writes: > >> I need this in order to allow aliases of the same form as "ls-tree", >> "rev-parse" etc, so that I can use >> >> [alias] >> my-cat=--paginate cat-file -p >> >> to add a "git my-cat" command. > > I do not have problem with this (and would perhaps also want to > add '_' to keychar set), but people who envisioned parsing > config from scripts (i.e. Perly git) might prefer if we stayed > within alnum, since I'd suspect then they may be able to reuse > existing .ini parsers. I do not much care about that myself, > but I am bringing it up just in case other people might. > > Other than that, this sounds nice. One thing I forgot to add. Just like we downcase what user has written in config file, it might make sense to also remove '-' (and if we add '_' to keychar set, that one as well) to when canonicalizing the key value. That way, somewhat awkward long configuration variables we currently have can be written more readably, e.g. repack.use-delta-base-offset Likes, dislikes? It is not strictly needed, since we can do CamelCase as well in the configuration file. > By the way, everybody seems to do "alias.xxx = -p cat-file -p" > (I have it as "git less"). Maybe we would want to make a > built-in alias for that? Seconds?