From: Junio C Hamano Date: Tue, 22 Jan 2008 23:42:27 GMT Subject: Re: [PATCH] git-commit: exit non-zero if we fail to commit the index Message-ID: <7vfxwpqvfg.fsf@gitster.siamese.dyndns.org> In-Reply-To: <47964370.8010300@nrlssc.navy.mil> Brandon Casey writes: > --- > > > Junio C Hamano wrote: >> Brandon Casey writes: >> >>>> We would need to tell the user that the index is not where >>>> it is when we detect the error, though. >>> The new index we are trying to rename will be deleted. >>> Are you saying we should >>> warn the user that the index is now out of sync? >> >> Yeah, something like that. But I think that once this happens >> there is no easy and sane recovery path for the user, as the >> most likely cause of the failure there would be the user running >> out of quota, so "git reset HEAD" which may be the way to >> recover from that failure would not have enough room to create a >> new index file anyway. > > If you're interested, here's a patch. Looks Ok from a quick glance. I am mired at day job this week so it may take a while for me to come up with a commit log message though.