From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 09 Feb 2008 05:31:32 GMT
Subject: Re: [PATCH] Introduce the config variable pack.packSizeLimit
Message-ID: <7vfxw2g0gb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0802051423530.8543@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> "git pack-objects" has the option --max-pack-size to limit the file
> size of the packs to a certain amount of bytes.  On platforms where
> the pack file size is limited by filesystem constraints, it is easy
> to forget this option, and this option does not exist for "git gc"
> to begin with.
>
> So introduce a config variable to set the default maximum, but make
> this overrideable by the command line.

The intention is good and all makes sense.

> +test_expect_success \
> +    'honor pack.packSizeLimit' \
> +    'git config pack.packSizeLimit 200 &&
> +     packname_4=$(git pack-objects test-4 <obj-list) &&
> +     test 3 = $(ls test-4-*.pack | wc -l)'
> +

Where does "3" come from, and what could break it?